RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:27:35 +00:00
Code Issues Activity Actions

AudioServer: Skip mixing when volume is zero

Browse source 
When volume is zero it is not necessary to go through the mixing loop.
The zero-filled buffer can be written directly to the device, instead,
similar to the muted case. Tested by using the piano app and the main
volume control.
This commit is contained in:
Alex Chronopoulos 2022-11-04 00:01:03 +01:00 • committed by Sam Atkins
parent 5822bc9cb5
commit e86cab00b6
1 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Services/AudioServer/Mixer.cpp
View file

@ -96,19 +96,15 @@ void Mixer::mix()
}
}
if (m_muted) {
// Even though it's not realistic, the user expects no sound at 0%.
if (m_muted || m_main_volume < 0.01) {
m_device->write(m_zero_filled_buffer.data(), static_cast<int>(m_zero_filled_buffer.size()));
} else {
Array<u8, HARDWARE_BUFFER_SIZE_BYTES> buffer;
OutputMemoryStream stream { buffer };
for (auto& mixed_sample : mixed_buffer) {
// Even though it's not realistic, the user expects no sound at 0%.
if (m_main_volume < 0.01)
mixed_sample = Audio::Sample { 0 };
else
mixed_sample.log_multiply(static_cast<float>(m_main_volume));
mixed_sample.log_multiply(static_cast<float>(m_main_volume));
mixed_sample.clip();
LittleEndian<i16> out_sample;