RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:57:44 +00:00
Code Issues Activity Actions

CrashReporter: Stop attempting to lockdown the process veil

Browse source 
The idea of locking the process veil in CrashReproter is well
intentioned, but ultimately frought with issues.

The fundamental premise is a bit flawed, as we are using the crashing
program as input to dynamically add new paths to the process veil.
This means that an attacker can potentially produce a custom or
malformed binary to trick CrashReporter into allowing an arbitrary
path to be read.
This commit is contained in:
Brian Gianforcaro 2022-02-03 00:24:32 -08:00 • committed by Andreas Kling
parent 6edb34aa56
commit e8857f9b2d
1 changed files with 0 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Userland/Applications/CrashReporter/main.cpp
View file

@ -163,27 +163,6 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
auto pid = coredump->process_pid();
auto termination_signal = coredump->process_termination_signal();
if (unlink_on_exit)
TRY(Core::System::unveil(coredump_path, "c"));
// If the executable is HackStudio, then the two unveil()s would conflict!
if (executable_path == "/bin/HackStudio") {
TRY(Core::System::unveil("/bin/HackStudio", "rx"));
} else {
TRY(Core::System::unveil(executable_path.characters(), "r"));
TRY(Core::System::unveil("/bin/HackStudio", "rx"));
}
TRY(Core::System::unveil("/res", "r"));
TRY(Core::System::unveil("/tmp/portal/launch", "rw"));
TRY(Core::System::unveil("/usr/lib", "r"));
coredump->for_each_library([&executable_path](auto library_info) {
// FIXME: Make for_each_library propagate ErrorOr values so we can use TRY.
if (library_info.path.starts_with('/') && library_info.path != executable_path)
MUST(Core::System::unveil(library_info.path, "r"));
});
TRY(Core::System::unveil(nullptr, nullptr));
auto app_icon = GUI::Icon::default_icon("app-crash-reporter");
auto window = TRY(GUI::Window::try_create());