From e8aa998cdcb64629fc615d03d0ba08f02424e931 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Sat, 27 Mar 2021 16:17:52 +0100 Subject: [PATCH] LibGUI: Return symlink fallback icon if target icon cannot be determined This is the case for symlinks that point to themselves, for example - previously the returned icon would be empty. Fixes #5978. Fixes #5979. --- Userland/Libraries/LibGUI/FileIconProvider.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Userland/Libraries/LibGUI/FileIconProvider.cpp b/Userland/Libraries/LibGUI/FileIconProvider.cpp index a56d638699..ac20948f1e 100644 --- a/Userland/Libraries/LibGUI/FileIconProvider.cpp +++ b/Userland/Libraries/LibGUI/FileIconProvider.cpp @@ -235,6 +235,8 @@ Icon FileIconProvider::icon_for_path(const String& path, mode_t mode) target_path = Core::File::real_path_for(String::formatted("{}/{}", LexicalPath(path).dirname(), raw_symlink_target)); } auto target_icon = icon_for_path(target_path); + if (target_icon.sizes().is_empty()) + return s_symlink_icon; Icon generated_icon; for (auto size : target_icon.sizes()) {