RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 06:52:45 +00:00
Code Issues Activity Actions

LibWeb: Make event dispatching spec-compliant

Browse source 
Specification: https://dom.spec.whatwg.org/#concept-event-dispatch

This also introduces shadow roots due to it being a requirement of
the event dispatcher.

However, it does not introduce the full shadow DOM, that can be
left for future work.

This changes some event dispatches which require certain attributes
to be initialised to a value.
This commit is contained in:
Luke 2020-11-21 18:32:39 +00:00 • committed by Andreas Kling
parent 819f099a8e
commit e8b3a65581
32 changed files with 858 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Libraries/LibWeb/DOM/Node.cpp
View file

@ -38,6 +38,7 @@
#include <LibWeb/DOM/EventDispatcher.h>
#include <LibWeb/DOM/EventListener.h>
#include <LibWeb/DOM/Node.h>
#include <LibWeb/DOM/ShadowRoot.h>
#include <LibWeb/HTML/HTMLAnchorElement.h>
#include <LibWeb/Layout/BlockBox.h>
#include <LibWeb/Layout/InitialContainingBlockBox.h>
@ -124,12 +125,9 @@ bool Node::is_link() const
return enclosing_link_element();
}
void Node::dispatch_event(NonnullRefPtr<Event> event)
bool Node::dispatch_event(NonnullRefPtr<Event> event)
{
EventDispatcher::dispatch(*this, event);
// FIXME: This is a hack. We should follow the real rules of event bubbling.
if (parent())
parent()->dispatch_event(move(event));
return EventDispatcher::dispatch(*this, event);
}
String Node::child_text_content() const
@ -145,17 +143,25 @@ String Node::child_text_content() const
return builder.build();
}
const Node* Node::root() const
Node* Node::root()
{
const Node* root = this;
Node* root = this;
while (root->parent())
root = root->parent();
return root;
}
Node* Node::shadow_including_root()
{
auto node_root = root();
if (is<ShadowRoot>(node_root))
return downcast<ShadowRoot>(node_root)->host()->shadow_including_root();
return node_root;
}
bool Node::is_connected() const
{
return root() && root()->is_document();
return shadow_including_root() && shadow_including_root()->is_document();
}
Element* Node::parent_element()
@ -238,4 +244,10 @@ void Node::set_layout_node(Badge<Layout::Node>, Layout::Node* layout_node) const
m_layout_node = nullptr;
}
EventTarget* Node::get_parent(const Event&)
{
// FIXME: returns the node’s assigned slot, if node is assigned, and node’s parent otherwise.
return parent();
}
}