RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:37:45 +00:00
Code Issues Activity Actions

LibWeb: Make event dispatching spec-compliant

Browse source 
Specification: https://dom.spec.whatwg.org/#concept-event-dispatch

This also introduces shadow roots due to it being a requirement of
the event dispatcher.

However, it does not introduce the full shadow DOM, that can be
left for future work.

This changes some event dispatches which require certain attributes
to be initialised to a value.
This commit is contained in:
Luke 2020-11-21 18:32:39 +00:00 • committed by Andreas Kling
parent 819f099a8e
commit e8b3a65581
32 changed files with 858 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Libraries/LibWeb/DOM/Node.h
View file

@ -60,7 +60,7 @@ public:
// ^EventTarget
virtual void ref_event_target() final { ref(); }
virtual void unref_event_target() final { unref(); }
virtual void dispatch_event(NonnullRefPtr<Event>) final;
virtual bool dispatch_event(NonnullRefPtr<Event>) final;
virtual Bindings::EventTargetWrapper* create_wrapper(JS::GlobalObject&) override;
virtual ~Node();
@ -76,7 +76,11 @@ public:
bool is_character_data() const { return type() == NodeType::TEXT_NODE || type() == NodeType::COMMENT_NODE; }
bool is_document_fragment() const { return type() == NodeType::DOCUMENT_FRAGMENT_NODE; }
bool is_parent_node() const { return is_element() || is_document() || is_document_fragment(); }
bool is_slottable() const { return is_element() || is_text(); }
virtual bool is_svg_element() const { return false; }
virtual bool is_shadow_root() const { return false; }
virtual bool is_node() const final { return true; }
virtual bool is_editable() const;
@ -102,7 +106,18 @@ public:
virtual bool is_html_element() const { return false; }
virtual bool is_unknown_html_element() const { return false; }
const Node* root() const;
Node* root();
const Node* root() const
{
return const_cast<Node*>(this)->root();
}
Node* shadow_including_root();
const Node* shadow_including_root() const
{
return const_cast<Node*>(this)->shadow_including_root();
}
bool is_connected() const;
Node* parent_node() { return parent(); }
@ -134,6 +149,8 @@ public:
void set_document(Badge<Document>, Document&);
virtual EventTarget* get_parent(const Event&) override;
protected:
Node(Document&, NodeType);
@ -144,3 +161,7 @@ protected:
};
}
AK_BEGIN_TYPE_TRAITS(Web::DOM::Node)
static bool is_type(const Web::DOM::EventTarget& event_target) { return event_target.is_node(); }
AK_END_TYPE_TRAITS()