RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 20:42:43 +00:00
Code Issues Activity Actions

LibC: __generate_unique_filename(): Replace rand() with arc4random()

Browse source 
LibC stdlib `arc4random()` uses the `getrandom` system call which
uses `KernelRng::get_good_random_bytes`.

This ensures that filenames generated using functions such as
`mkstemp()` are suitably randomised and are no longer predictable.
This commit is contained in:
Brendan Coles 2020-12-22 20:58:40 +00:00 • committed by Andreas Kling
parent cef6b7b2e4
commit e8e8d3caf5
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibC/stdlib.cpp
View file

@ -186,7 +186,7 @@ __attribute__((warn_unused_result)) int __generate_unique_filename(char* pattern
for (int attempt = 0; attempt < 100; ++attempt) { for (int attempt = 0; attempt < 100; ++attempt) {
for (int i = 0; i < 6; ++i) for (int i = 0; i < 6; ++i)
pattern[start + i] = random_characters[(rand() % (sizeof(random_characters) - 1))]; pattern[start + i] = random_characters[(arc4random() % (sizeof(random_characters) - 1))];
struct stat st; struct stat st;
int rc = lstat(pattern, &st); int rc = lstat(pattern, &st);
if (rc < 0 && errno == ENOENT) if (rc < 0 && errno == ENOENT)