From e91b2c57c197604943bf2c59aea2c5a843243c29 Mon Sep 17 00:00:00 2001
From: Andreas Kling <kling@serenityos.org>
Date: Tue, 15 Feb 2022 18:48:30 +0100
Subject: [PATCH] LibWeb: Allow label activation via any descendant of the
 label node

Previously we were only forwarding the activation to the labelled
control if the user clicked on an immediate child of <label>.
---
 Userland/Libraries/LibWeb/Layout/TextNode.cpp | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/Userland/Libraries/LibWeb/Layout/TextNode.cpp b/Userland/Libraries/LibWeb/Layout/TextNode.cpp
index ba766ec9f9..c5d2abe731 100644
--- a/Userland/Libraries/LibWeb/Layout/TextNode.cpp
+++ b/Userland/Libraries/LibWeb/Layout/TextNode.cpp
@@ -207,34 +207,37 @@ void TextNode::compute_text_for_rendering(bool collapse, bool previous_is_empty_
 
 bool TextNode::wants_mouse_events() const
 {
-    return parent() && is<Label>(parent());
+    return first_ancestor_of_type<Label>();
 }
 
 void TextNode::handle_mousedown(Badge<EventHandler>, const Gfx::IntPoint& position, unsigned button, unsigned)
 {
-    if (!parent() || !is<Label>(*parent()))
+    auto* label = first_ancestor_of_type<Label>();
+    if (!label)
         return;
-    verify_cast<Label>(*parent()).handle_mousedown_on_label({}, position, button);
+    label->handle_mousedown_on_label({}, position, button);
     browsing_context().event_handler().set_mouse_event_tracking_layout_node(this);
 }
 
 void TextNode::handle_mouseup(Badge<EventHandler>, const Gfx::IntPoint& position, unsigned button, unsigned)
 {
-    if (!parent() || !is<Label>(*parent()))
+    auto* label = first_ancestor_of_type<Label>();
+    if (!label)
         return;
 
     // NOTE: Changing the state of the DOM node may run arbitrary JS, which could disappear this node.
     NonnullRefPtr protect = *this;
 
-    verify_cast<Label>(*parent()).handle_mouseup_on_label({}, position, button);
+    label->handle_mouseup_on_label({}, position, button);
     browsing_context().event_handler().set_mouse_event_tracking_layout_node(nullptr);
 }
 
 void TextNode::handle_mousemove(Badge<EventHandler>, const Gfx::IntPoint& position, unsigned button, unsigned)
 {
-    if (!parent() || !is<Label>(*parent()))
+    auto* label = first_ancestor_of_type<Label>();
+    if (!label)
         return;
-    verify_cast<Label>(*parent()).handle_mousemove_on_label({}, position, button);
+    label->handle_mousemove_on_label({}, position, button);
 }
 
 TextNode::ChunkIterator::ChunkIterator(StringView text, LayoutMode layout_mode, bool wrap_lines, bool respect_linebreaks)