RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:57:44 +00:00
Code Issues Activity Actions

LibVT+Terminal: Don't set window title directly from TerminalWidget

Browse source 
Instead, have TerminalWidget provide an on_title_change hook.
This allows embedders to decide for themselves what to do if we receive
a "set terminal title" escape sequence.
This commit is contained in:
Andreas Kling 2019-10-21 22:07:59 +02:00
parent 3fa16dfae2
commit e9f6e1e287
3 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibVT/TerminalWidget.cpp
View file

@ -323,10 +323,8 @@ void TerminalWidget::paint_event(GPaintEvent& event)
void TerminalWidget::set_window_title(const StringView& title)
{
auto* w = window();
if (!w)
return;
w->set_title(title);
if (on_title_change)
on_title_change(title);
}
void TerminalWidget::invalidate_cursor()

2
Libraries/LibVT/TerminalWidget.h
View file

@ -43,6 +43,8 @@ public:
virtual bool accepts_focus() const override { return true; }
Function<void(const StringView&)> on_title_change;
private:
// ^GWidget
virtual void event(CEvent&) override;