RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 17:32:44 +00:00
Code Issues Activity Actions

Assistant: Zero initialize fuzzy match array

Browse source 
SonarCloud flagged the read of the matches array as a potential garbage
read. I don't believe the case it flagged was possible to reach due to
how the code is structured, however we should really just be zero
initializing these stack arrays.
This commit is contained in:
Brian Gianforcaro 2021-09-27 19:39:46 -07:00 • committed by Andreas Kling
parent 998234f9e9
commit ea2d68d14b
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/Assistant/FuzzyMatch.cpp
View file

@ -51,7 +51,7 @@ static FuzzyMatchResult fuzzy_match_recursive(String const& needle, String const
first_match = false;
}
u8 recursive_matches[recursive_match_limit];
u8 recursive_matches[recursive_match_limit] {};
auto result = fuzzy_match_recursive(needle, haystack, needle_idx, haystack_idx + 1, matches, recursive_matches, next_match, recursion_count);
if (result.matched) {
if (!had_recursive_match || result.score > best_recursive_score) {
@ -116,7 +116,7 @@ static FuzzyMatchResult fuzzy_match_recursive(String const& needle, String const
FuzzyMatchResult fuzzy_match(String needle, String haystack)
{
int recursion_count = 0;
u8 matches[MAX_MATCHES];
u8 matches[MAX_MATCHES] {};
return fuzzy_match_recursive(needle, haystack, 0, 0, nullptr, matches, 0, recursion_count);
}