RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:17:46 +00:00
Code Issues Activity Actions

Libraries: Use default constructors/destructors in LibCore

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-26 09:09:45 -07:00 • committed by Brian Gianforcaro
parent c6dcb12b00
commit ea58b8d927
23 changed files with 46 additions and 74 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibCore/MimeData.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -17,7 +18,7 @@ class MimeData : public Object {
C_OBJECT(MimeData);
public:
virtual ~MimeData() { }
virtual ~MimeData() = default;
ByteBuffer data(const String& mime_type) const { return m_data.get(mime_type).value_or({}); }
void set_data(const String& mime_type, ByteBuffer&& data) { m_data.set(mime_type, move(data)); }
@ -38,7 +39,7 @@ public:
const HashMap<String, ByteBuffer>& all_data() const { return m_data; }
private:
MimeData() { }
MimeData() = default;
explicit MimeData(const HashMap<String, ByteBuffer>& data)
: m_data(data)
{