RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 04:27:45 +00:00
Code Issues Activity Actions

Libraries: Use default constructors/destructors in LibCore

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-26 09:09:45 -07:00 • committed by Brian Gianforcaro
parent c6dcb12b00
commit ea58b8d927
23 changed files with 46 additions and 74 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibCore/NetworkJob.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -24,7 +25,7 @@ public:
ProtocolFailed,
Cancelled,
};
virtual ~NetworkJob() override;
virtual ~NetworkJob() override = default;
// Could fire twice, after Headers and after Trailers!
Function<void(const HashMap<String, String, CaseInsensitiveStringTraits>& response_headers, Optional<u32> response_code)> on_headers_received;