RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:57:45 +00:00
Code Issues Activity Actions

LibCrypto: Update entire blocks in SHA*::update()

Browse source 
Instead of going byte by byte, copy entire blocks at once and only check
if we need to update the state once per block. This pretty much
eliminates `::update()` from profiles and measurably improves
performance for utilities like `sha256sum`.
This commit is contained in:
Jelle Raaijmakers 2023-03-24 01:43:32 +01:00 • committed by Linus Groh
parent 0606d371fe
commit ea9707ec29
2 changed files with 40 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibCrypto/Hash/SHA1.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Ali Mohammad Pur <mpfard@serenityos.org>
* Copyright (c) 2023, Jelle Raaijmakers <jelle@gmta.nl>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -68,13 +69,17 @@ inline void SHA1::transform(u8 const* data)
void SHA1::update(u8 const* message, size_t length)
{
for (size_t i = 0; i < length; ++i) {
while (length > 0) {
size_t copy_bytes = AK::min(length, BlockSize - m_data_length);
__builtin_memcpy(m_data_buffer + m_data_length, message, copy_bytes);
message += copy_bytes;
length -= copy_bytes;
m_data_length += copy_bytes;
if (m_data_length == BlockSize) {
transform(m_data_buffer);
m_bit_length += 512;
m_bit_length += BlockSize * 8;
m_data_length = 0;
}
m_data_buffer[m_data_length++] = message[i];
}
}
@ -96,13 +101,6 @@ SHA1::DigestType SHA1::peek()
__builtin_memcpy(data, m_data_buffer, m_data_length);
__builtin_memcpy(state, m_state, 20);
if (BlockSize == m_data_length) {
transform(m_data_buffer);
m_bit_length += BlockSize * 8;
m_data_length = 0;
i = 0;
}
if (m_data_length < FinalBlockDataSize) {
m_data_buffer[i++] = 0x80;
while (i < FinalBlockDataSize)