RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-23 17:45:07 +00:00
Code Issues Activity Actions

WindowServer+LibGUI: Force full window repaints after theme change

Browse source 
We were not repainting windows that were occluded at the time of the
theme changing. This patch adds a way to bypass occlusion testing when
invalidating window rects.

Fixes #1249.
This commit is contained in:
Andreas Kling 2020-02-19 16:45:06 +01:00
parent 8a2dc5d188
commit eaa680ab8e
7 changed files with 20 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Servers/WindowServer/ClientConnection.cpp
View file

@ -465,10 +465,10 @@ OwnPtr<Messages::WindowServer::DestroyWindowResponse> ClientConnection::handle(c
return make<Messages::WindowServer::DestroyWindowResponse>();
}
void ClientConnection::post_paint_message(Window& window)
void ClientConnection::post_paint_message(Window& window, bool ignore_occlusion)
{
auto rect_set = window.take_pending_paint_rects();
if (window.is_minimized() || window.is_occluded())
if (window.is_minimized() || (!ignore_occlusion && window.is_occluded()))
return;
post_message(Messages::WindowClient::Paint(window.window_id(), window.size(), rect_set.rects()));
@ -483,7 +483,7 @@ void ClientConnection::handle(const Messages::WindowServer::InvalidateRect& mess
}
auto& window = *(*it).value;
for (int i = 0; i < message.rects().size(); ++i)
window.request_update(message.rects()[i].intersected({ {}, window.size() }));
window.request_update(message.rects()[i].intersected({ {}, window.size() }), message.ignore_occlusion());
}
void ClientConnection::handle(const Messages::WindowServer::DidFinishPainting& message)