RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:07:35 +00:00
Code Issues Activity Actions

GUI: Extract a ScrollBar::scroll_to_position method

Browse source
This commit is contained in:
Nico Weber 2020-08-11 20:56:52 -04:00 • committed by Andreas Kling
parent d1571ce00a
commit eab7712ab0
2 changed files with 21 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Libraries/LibGUI/ScrollBar.cpp
View file

@ -294,19 +294,7 @@ void ScrollBar::mousedown_event(MouseEvent& event)
return; return;
} }
float range_size = m_max - m_min; scroll_to_position(event.position());
float available = scrubbable_range_in_pixels();
float x = ::max(0, event.position().x() - button_width() - button_width() / 2);
float y = ::max(0, event.position().y() - button_height() - button_height() / 2);
float rel_x = x / available;
float rel_y = y / available;
if (orientation() == Orientation::Vertical)
set_value(m_min + rel_y * range_size);
else
set_value(m_min + rel_x * range_size);
m_scrubbing = true; m_scrubbing = true;
m_scrub_start_value = value(); m_scrub_start_value = value();
@ -342,6 +330,24 @@ void ScrollBar::set_automatic_scrolling_active(bool active)
} }
} }
void ScrollBar::scroll_to_position(const Gfx::IntPoint& position)
{
float range_size = m_max - m_min;
float available = scrubbable_range_in_pixels();
float x = ::max(0, position.x() - button_width() - button_width() / 2);
float y = ::max(0, position.y() - button_height() - button_height() / 2);
float rel_x = x / available;
float rel_y = y / available;
if (orientation() == Orientation::Vertical)
set_value(m_min + rel_y * range_size);
else
set_value(m_min + rel_x * range_size);
}
void ScrollBar::mousemove_event(MouseEvent& event) void ScrollBar::mousemove_event(MouseEvent& event)
{ {
auto old_hovered_component = m_hovered_component; auto old_hovered_component = m_hovered_component;

2
Libraries/LibGUI/ScrollBar.h
View file

@ -92,6 +92,8 @@ private:
void on_automatic_scrolling_timer_fired(); void on_automatic_scrolling_timer_fired();
void set_automatic_scrolling_active(bool); void set_automatic_scrolling_active(bool);
void scroll_to_position(const Gfx::IntPoint&);
int m_min { 0 }; int m_min { 0 };
int m_max { 0 }; int m_max { 0 };
int m_page { 0 }; int m_page { 0 };