From ead311eac7bc135ce0b6a2c26ba2d283121448dc Mon Sep 17 00:00:00 2001 From: Aliaksandr Kalenik Date: Wed, 13 Sep 2023 23:32:26 +0200 Subject: [PATCH] LibWeb: Delete navigation id check in navigate_to_a_javascript_url Adding this check was a mistake because although the navigation id changes to null in step 2, it still has to proceed and apply the history step. --- Userland/Libraries/LibWeb/HTML/Navigable.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Userland/Libraries/LibWeb/HTML/Navigable.cpp b/Userland/Libraries/LibWeb/HTML/Navigable.cpp index 80b2478ab0..49c0849e3f 100644 --- a/Userland/Libraries/LibWeb/HTML/Navigable.cpp +++ b/Userland/Libraries/LibWeb/HTML/Navigable.cpp @@ -1320,10 +1320,6 @@ WebIDL::ExceptionOr Navigable::navigate_to_a_javascript_url(AK::URL const& // 13. Append session history traversal steps to targetNavigable's traversable to finalize a cross-document navigation with targetNavigable, historyHandling, and historyEntry. traversable_navigable()->append_session_history_traversal_steps([this, history_entry, history_handling, navigation_id] { - if (this->ongoing_navigation() != navigation_id) { - // NOTE: This check is not in the spec but we should not continue navigation if ongoing navigation id has changed. - return; - } finalize_a_cross_document_navigation(*this, history_handling, history_entry); });