RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-09 19:42:06 +00:00
Code Issues Activity Actions

LibJS: Properly compute the line for source location hints

Browse source 
These were obvious wrong uses of the old default "only first occurence"
parameter that was used in String::replace.
This commit is contained in:
DexesTTP 2022-07-05 22:50:14 +02:00 • committed by Linus Groh
parent e371552ff2
commit eae8520dbb
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Parser.h
View file

@ -182,7 +182,7 @@ public:
return {}; return {};
// We need to modify the source to match what the lexer considers one line - normalizing // We need to modify the source to match what the lexer considers one line - normalizing
// line terminators to \n is easier than splitting using all different LT characters. // line terminators to \n is easier than splitting using all different LT characters.
String source_string = source.replace("\r\n", "\n", ReplaceMode::FirstOnly).replace("\r", "\n", ReplaceMode::FirstOnly).replace(LINE_SEPARATOR_STRING, "\n", ReplaceMode::FirstOnly).replace(PARAGRAPH_SEPARATOR_STRING, "\n", ReplaceMode::FirstOnly); String source_string = source.replace("\r\n", "\n", ReplaceMode::All).replace("\r", "\n", ReplaceMode::All).replace(LINE_SEPARATOR_STRING, "\n", ReplaceMode::All).replace(PARAGRAPH_SEPARATOR_STRING, "\n", ReplaceMode::All);
StringBuilder builder; StringBuilder builder;
builder.append(source_string.split_view('\n', true)[position.value().line - 1]); builder.append(source_string.split_view('\n', true)[position.value().line - 1]);
builder.append('\n'); builder.append('\n');