From eb4a69c377362f04c74ef3d81658b591e611b405 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 19 Feb 2023 23:52:10 +0100 Subject: [PATCH] LibImageDecoderClient: Fix minor const-correctness issue By taking ownership of the bitmaps after decoding them, we avoid having to call an API that would give us a const Bitmap. --- Userland/Libraries/LibImageDecoderClient/Client.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibImageDecoderClient/Client.cpp b/Userland/Libraries/LibImageDecoderClient/Client.cpp index 404e061f10..93b1e59a05 100644 --- a/Userland/Libraries/LibImageDecoderClient/Client.cpp +++ b/Userland/Libraries/LibImageDecoderClient/Client.cpp @@ -49,9 +49,10 @@ Optional Client::decode_image(ReadonlyBytes encoded_data, Optional image.is_animated = response.is_animated(); image.loop_count = response.loop_count(); image.frames.resize(response.bitmaps().size()); + auto bitmaps = response.take_bitmaps(); for (size_t i = 0; i < image.frames.size(); ++i) { auto& frame = image.frames[i]; - frame.bitmap = response.bitmaps()[i].bitmap(); + frame.bitmap = bitmaps[i].bitmap(); frame.duration = response.durations()[i]; } return image;