RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:27:35 +00:00
Code Issues Activity Actions

LibJS: Don't assert for empty reciever if AllowSideEffects::No is given

Browse source 
This parameter is only used if AllowSideEffects::Yes, so there's no
reason to pass anything to it if that's not used.
This commit is contained in:
Ali Mohammad Pur 2021-06-21 08:40:57 +04:30 • committed by Ali Mohammad Pur
parent e523e530fc
commit eb5c92d4e2
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/Object.cpp
View file

@ -251,7 +251,6 @@ bool Object::test_integrity_level(IntegrityLevel level)
Value Object::get_own_property(const PropertyName& property_name, Value receiver, AllowSideEffects allow_side_effects) const Value Object::get_own_property(const PropertyName& property_name, Value receiver, AllowSideEffects allow_side_effects) const
{ {
VERIFY(property_name.is_valid()); VERIFY(property_name.is_valid());
VERIFY(!receiver.is_empty());
Value value_here; Value value_here;
@ -269,6 +268,7 @@ Value Object::get_own_property(const PropertyName& property_name, Value receiver
VERIFY(!value_here.is_empty()); VERIFY(!value_here.is_empty());
if (allow_side_effects == AllowSideEffects::Yes) { if (allow_side_effects == AllowSideEffects::Yes) {
VERIFY(!receiver.is_empty());
if (value_here.is_accessor()) if (value_here.is_accessor())
return value_here.as_accessor().call_getter(receiver); return value_here.as_accessor().call_getter(receiver);
if (value_here.is_native_property()) if (value_here.is_native_property())