RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:47:35 +00:00
Code Issues Activity Actions

LibJS: Convert Interpreter::run() to ThrowCompletionOr<Value>

Browse source 
Instead of making it a void function, checking for an exception, and
then receiving the relevant result via VM::last_value(), we can
consolidate all of this by using completions.

This allows us to remove more uses of VM::exception(), and all uses of
VM::last_value().
This commit is contained in:
Linus Groh 2022-01-08 21:28:27 +01:00
parent f73afbb5ae
commit eb60d16549
13 changed files with 62 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Applications/Assistant/Providers.cpp
View file

@ -98,11 +98,11 @@ void CalculatorProvider::query(String const& query, Function<void(NonnullRefPtrV
if (parser.has_errors())
return;
interpreter->run(interpreter->global_object(), *program);
if (interpreter->exception())
auto completion = interpreter->run(interpreter->global_object(), *program);
if (completion.is_error())
return;
auto result = interpreter->vm().last_value();
auto result = completion.release_value();
String calculation;
if (!result.is_number()) {
calculation = "0";