From eba3fa5e72e0dd204ef5d2220ceaad74220e2a9f Mon Sep 17 00:00:00 2001 From: Hendiadyoin1 Date: Sat, 27 Feb 2021 23:15:01 +0100 Subject: [PATCH] Kernel: Make munmap more posix compliant In case someone tries to unmap a not mapped region (fallback) we should not return an error, but silently do nothing --- Kernel/Syscalls/mmap.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Kernel/Syscalls/mmap.cpp b/Kernel/Syscalls/mmap.cpp index 4d07e44643..68447db9f2 100644 --- a/Kernel/Syscalls/mmap.cpp +++ b/Kernel/Syscalls/mmap.cpp @@ -494,9 +494,6 @@ KResultOr Process::sys$munmap(Userspace addr, size_t size) // Try again while checkin multiple regions at a time // slow: without caching const auto& regions = space().find_regions_intersecting(range_to_unmap); - // if there still no regions found error out - if (!regions.size()) - return EINVAL; // check if any of the regions is not mmaped, to not accientally // error-out with just half a region map left @@ -529,6 +526,7 @@ KResultOr Process::sys$munmap(Userspace addr, size_t size) for (auto* new_region : new_regions) { new_region->map(space().page_directory()); } + return 0; }