RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:27:43 +00:00
Code Issues Activity Actions

SystemMonitor: Only update kill actions when pid changes

Browse source 
Return early from on_selection_change if the pid hasn't changed or we
get an invalid result from selected_id().
This commit is contained in:
Marcus Nilsson 2021-07-28 00:23:34 +02:00 • committed by Andreas Kling
parent 5fbb476856
commit ebb96b7fea
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Applications/SystemMonitor/main.cpp
View file

@ -353,8 +353,13 @@ int main(int argc, char** argv)
process_properties_action->activate(); process_properties_action->activate();
}; };
static pid_t last_selected_pid;
process_table_view.on_selection_change = [&] { process_table_view.on_selection_change = [&] {
pid_t pid = selected_id(ProcessModel::Column::PID); pid_t pid = selected_id(ProcessModel::Column::PID);
if (pid == last_selected_pid || pid < 1)
return;
last_selected_pid = pid;
bool has_access = can_access_pid(pid); bool has_access = can_access_pid(pid);
kill_action->set_enabled(has_access); kill_action->set_enabled(has_access);
stop_action->set_enabled(has_access); stop_action->set_enabled(has_access);