RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 20:17:44 +00:00
Code Issues Activity Actions

LibWeb: Only make certain <body> and <frameset> events apply to Window

Browse source 
Previously we forwarded all event handler attributes to Window from
these two elements, however, we are only supposed to forward blur,
error, focus, load, resize and scroll.
This commit is contained in:
Luke Wilde 2022-06-27 19:20:09 +01:00 • committed by Linus Groh
parent a50a48f6b4
commit ebf2184636
11 changed files with 37 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/Document.h
View file

@ -353,7 +353,7 @@ private:
explicit Document(const AK::URL&);
// ^HTML::GlobalEventHandlers
virtual EventTarget& global_event_handlers_to_event_target() final { return *this; }
virtual EventTarget& global_event_handlers_to_event_target(FlyString const&) final { return *this; }
void tear_down_layout_tree();

2
Userland/Libraries/LibWeb/DOM/EventTarget.cpp
View file

@ -218,7 +218,7 @@ ExceptionOr<bool> EventTarget::dispatch_event_binding(NonnullRefPtr<Event> event
}
// https://html.spec.whatwg.org/multipage/webappapis.html#window-reflecting-body-element-event-handler-set
static bool is_window_reflecting_body_element_event_handler(FlyString const& name)
bool is_window_reflecting_body_element_event_handler(FlyString const& name)
{
return name.is_one_of(
HTML::EventNames::blur,

2
Userland/Libraries/LibWeb/DOM/EventTarget.h
View file

@ -86,4 +86,6 @@ private:
JS::ThrowCompletionOr<void> process_event_handler_for_event(FlyString const& name, Event& event);
};
bool is_window_reflecting_body_element_event_handler(FlyString const& name);
}