From ec1891837fd2aeec9b644ca1b70caf6f026e305a Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 4 Jun 2020 16:04:52 +0200 Subject: [PATCH] LibWeb: Fix and elements not parsing their class attribute Subclasses that override Element::parse_attribute() must always call to base class since otherwise we might forget to parse some attributes. This makes class selectors work on and elements. :^) --- Libraries/LibWeb/DOM/HTMLBodyElement.cpp | 1 + Libraries/LibWeb/DOM/HTMLImageElement.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/Libraries/LibWeb/DOM/HTMLBodyElement.cpp b/Libraries/LibWeb/DOM/HTMLBodyElement.cpp index 260110b0fb..1dd96a4341 100644 --- a/Libraries/LibWeb/DOM/HTMLBodyElement.cpp +++ b/Libraries/LibWeb/DOM/HTMLBodyElement.cpp @@ -60,6 +60,7 @@ void HTMLBodyElement::apply_presentational_hints(StyleProperties& style) const void HTMLBodyElement::parse_attribute(const FlyString& name, const String& value) { + HTMLElement::parse_attribute(name, value); if (name.equals_ignoring_case("link")) { auto color = Color::from_string(value); if (color.has_value()) diff --git a/Libraries/LibWeb/DOM/HTMLImageElement.cpp b/Libraries/LibWeb/DOM/HTMLImageElement.cpp index 97b718d7e3..adeacc3cb0 100644 --- a/Libraries/LibWeb/DOM/HTMLImageElement.cpp +++ b/Libraries/LibWeb/DOM/HTMLImageElement.cpp @@ -48,6 +48,7 @@ HTMLImageElement::~HTMLImageElement() void HTMLImageElement::parse_attribute(const FlyString& name, const String& value) { + HTMLElement::parse_attribute(name, value); if (name.equals_ignoring_case("src")) load_image(value); }