RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:07:45 +00:00
Code Issues Activity Actions

LibWeb: Support RadioNodeList named items in HTMLFormControlsCollection

Browse source 
We would previously not return a RadioNodeList in the curious case where
a named item resolves to two different elements within the form.

This was not a problem when calling namedItem directly in the IDL as
named_item_or_radio_node_list shadows named_item but is exposed when
calling the property through array bracket notation (as an example).

Fix this, and add a bunch more tests to cover
HTMLFormControlsCollection.
This commit is contained in:
Shannon Booth 2023-12-21 22:04:26 +13:00 • committed by Andreas Kling
parent 1defc4595b
commit ec2b4c271f
4 changed files with 133 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

55
Tests/LibWeb/Text/input/html-form-controls-collection.html
View file

@ -1,24 +1,57 @@
<form>
<input name="one" id="my-form-control" type="button" />
<input name="two" id="my-form-control" type="text" />
<input name="one" id="formcontrol" type="button" />
<input name="two" id="formcontrol" type="text" />
</form>
<script src="include.js"></script>
<script>
test(() => {
const formElements = document.forms[0].elements;
const radioNodeList = formElements.namedItem("my-form-control");
function printDescription(name) {
println("-------------------");
println(name);
println("-------------------");
}
println(formElements.constructor.name);
function dumpInput(name, item) {
printDescription(name);
println(item.constructor.name);
println(item.id);
println(item.type);
}
function dumpRadioNodeList(name, radioNodeList) {
printDescription(name);
println(radioNodeList.constructor.name);
println(radioNodeList.length);
println(radioNodeList[0].type);
println(radioNodeList[1].type);
}
const nonMatching = formElements.namedItem("no match");
println(nonMatching);
function dumpNoMatch(name, item) {
printDescription(name);
println(item);
}
const singleElement = formElements.namedItem("two");
println(singleElement.constructor.name);
println(singleElement.type);
test(() => {
const form = document.forms[0].elements;
println(form.constructor.name);
println(form.length);
dumpRadioNodeList('form.namedItem("formcontrol")', form.namedItem("formcontrol"))
dumpInput('form.namedItem("one")', form.namedItem("one"));
dumpInput('form.namedItem("two")', form.namedItem("two"));
dumpNoMatch('form.namedItem("nomatch")', form.namedItem("nomatch"));
dumpRadioNodeList('form["formcontrol"]', form["formcontrol"])
dumpInput('form["one"]', form["one"]);
dumpInput('form["two"]', form["two"]);
dumpNoMatch('form["nomatch"]', form["nomatch"]);
dumpRadioNodeList('form.formcontrol', form.formcontrol)
dumpInput('form.one', form.one);
dumpInput('form.two', form.two);
dumpNoMatch('form.nomatch', form.nomatch);
dumpInput('form[0]', form[0]);
dumpInput('form[1]', form[1]);
dumpNoMatch('form[2]', form[2]);
})
</script>