RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:07:34 +00:00
Code Issues Activity Actions

LibJS: Implement IteratorClose with Completions and align to the spec

Browse source
This commit is contained in:
Timothy Flynn 2021-10-20 13:36:14 -04:00 • committed by Linus Groh
parent 04b4307b3d
commit ec54a7b5b0
8 changed files with 97 additions and 79 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibJS/Runtime/VM.cpp
View file

@ -202,11 +202,13 @@ ThrowCompletionOr<void> VM::binding_initialization(NonnullRefPtr<BindingPattern>
auto result = iterator_binding_initialization(*target, iterator, iterator_done, environment, global_object);
if (!iterator_done) {
// FIXME: Iterator close should take result and potentially return that. This logic should achieve the same until that is possible.
iterator_close(*iterator);
if (auto* thrown_exception = exception())
return JS::throw_completion(thrown_exception->value());
// iterator_close() always returns a Completion, which ThrowCompletionOr will interpret as a throw
// completion. So only return the result of iterator_close() if it is indeed a throw completion.
auto completion = result.is_throw_completion() ? result.release_error() : normal_completion({});
if (completion = iterator_close(*iterator, move(completion)); completion.is_error())
return completion.release_error();
}
return result;
}
}