RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 02:42:44 +00:00
Code Issues Activity Actions

WindowServer: Don't "enter" menu item when hovering over a separator

Browse source 
Since menu separator items don't have an associated identifier,
make sure we don't falsely report that we've enter item 0.

This fixes an issue where hovering over a separator would behave
as if we'd hovered over the first item in the menu wrt sending
MenuItemEntered.
This commit is contained in:
Andreas Kling 2021-04-17 18:50:10 +02:00
parent e67f392576
commit ec6debb46f
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Services/WindowServer/Menu.cpp
View file

@ -556,8 +556,11 @@ int Menu::item_index_at(const Gfx::IntPoint& position)
{
int i = 0;
for (auto& item : m_items) {
if (item.rect().contains(position))
if (item.rect().contains(position)) {
if (item.type() == MenuItem::Type::Separator)
return -1;
return i;
}
++i;
}
return -1;