RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-02 23:22:07 +00:00
Code Issues Activity Actions

Kernel: Changed serial debug functions and variables for readability

Browse source 
Change the name of set_serial_debug(bool on_or_off) to
set_serial_debug_enabled(bool desired_state). This is to make the names
more expressive and less unclear as to what the function does, as it
only sets the enabled state.
Likewise, change the name of get_serial_debug() to
is_serial_debug_enabled() in order to make clear from the name that
this is simply the state of s_serial_debug_enabled.
Change the name of serial_debug to s_serial_debug_enabled since this is
a static bool describing this state.
Finally, change the signature of set_serial_debug_enabled to return a
bool, as this is more logical and understandable.
This commit is contained in:
Skye Sprung 2022-08-24 23:49:23 +02:00 • committed by Sam Atkins
parent cd763de280
commit eca85f2050
3 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/kstdio.h
View file

@ -15,8 +15,8 @@ void kernelputstr(char const*, size_t);
void kernelcriticalputstr(char const*, size_t);
void kernelearlyputstr(char const*, size_t);
int snprintf(char* buf, size_t, char const* fmt, ...) __attribute__((format(printf, 3, 4)));
void set_serial_debug(bool on_or_off);
int get_serial_debug();
void set_serial_debug_enabled(bool desired_state);
bool is_serial_debug_enabled();
}
void dbgputstr(StringView view);