RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 12:48:10 +00:00
Code Issues Activity Actions

WindowServer: Control WSClientConnection's window list teardown better

Browse source 
A lot of things happen in response to window destruction, and some of
them may call into the window's WSClientConnection and ask it to look
through its window list.

If we're right in the middle of tearing down the window list, it's not
a great idea to start iterating over it.

Fixes #386.
This commit is contained in:
Andreas Kling 2019-07-31 10:00:16 +02:00
parent a82c60b22a
commit eccc3c3ef0
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Servers/WindowServer/WSClientConnection.cpp
View file

@ -50,6 +50,10 @@ WSClientConnection::WSClientConnection(CLocalSocket& client_socket, int client_i
WSClientConnection::~WSClientConnection()
{
// NOTE: Move the windows out of 'm_windows' before teardown. This prevents code
// that runs in response to window destruction from trying to iterate over
// a partially destroyed window list.
auto windows = move(m_windows);
s_connections->remove(client_id());
}