RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-20 14:05:08 +00:00
Code Issues Activity Actions

LibWeb: Simplify table_containing_cell signature and implementation

Browse source 
Reflect expectations of its only call site.
This commit is contained in:
Andi Gallo 2023-08-30 09:46:26 +00:00 • committed by Alexander Kalenik
parent 258a6cb126
commit ece122353b
1 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibWeb/HTML/HTMLTableCellElement.cpp
View file

@ -32,14 +32,12 @@ void HTMLTableCellElement::initialize(JS::Realm& realm)
set_prototype(&Bindings::ensure_web_prototype<Bindings::HTMLTableCellElementPrototype>(realm, "HTMLTableCellElement")); set_prototype(&Bindings::ensure_web_prototype<Bindings::HTMLTableCellElementPrototype>(realm, "HTMLTableCellElement"));
} }
static const HTML::HTMLTableElement* table_containing_cell(const DOM::Node* node) static const HTML::HTMLTableElement& table_containing_cell(const HTML::HTMLTableCellElement& node)
{ {
if (!is<const HTML::HTMLTableCellElement>(node)) auto parent_node = node.parent();
return nullptr;
auto parent_node = node->parent();
while (!is<HTML::HTMLTableElement>(parent_node)) while (!is<HTML::HTMLTableElement>(parent_node))
parent_node = parent_node->parent(); parent_node = parent_node->parent();
return static_cast<const HTML::HTMLTableElement*>(parent_node); return static_cast<const HTML::HTMLTableElement&>(*parent_node);
} }
void HTMLTableCellElement::apply_presentational_hints(CSS::StyleProperties& style) const void HTMLTableCellElement::apply_presentational_hints(CSS::StyleProperties& style) const
@ -80,14 +78,14 @@ void HTMLTableCellElement::apply_presentational_hints(CSS::StyleProperties& styl
return; return;
} }
}); });
auto table_element = table_containing_cell(this); auto const& table_element = table_containing_cell(*this);
auto border = table_element->border(); auto border = table_element.border();
if (!border) if (!border)
return; return;
auto apply_border_style = [&](CSS::PropertyID style_property, CSS::PropertyID width_property, CSS::PropertyID color_property) { auto apply_border_style = [&](CSS::PropertyID style_property, CSS::PropertyID width_property, CSS::PropertyID color_property) {
style.set_property(style_property, CSS::IdentifierStyleValue::create(CSS::ValueID::Inset)); style.set_property(style_property, CSS::IdentifierStyleValue::create(CSS::ValueID::Inset));
style.set_property(width_property, CSS::LengthStyleValue::create(CSS::Length::make_px(1))); style.set_property(width_property, CSS::LengthStyleValue::create(CSS::Length::make_px(1)));
style.set_property(color_property, table_element->computed_css_values()->property(color_property)); style.set_property(color_property, table_element.computed_css_values()->property(color_property));
}; };
apply_border_style(CSS::PropertyID::BorderLeftStyle, CSS::PropertyID::BorderLeftWidth, CSS::PropertyID::BorderLeftColor); apply_border_style(CSS::PropertyID::BorderLeftStyle, CSS::PropertyID::BorderLeftWidth, CSS::PropertyID::BorderLeftColor);
apply_border_style(CSS::PropertyID::BorderTopStyle, CSS::PropertyID::BorderTopWidth, CSS::PropertyID::BorderTopColor); apply_border_style(CSS::PropertyID::BorderTopStyle, CSS::PropertyID::BorderTopWidth, CSS::PropertyID::BorderTopColor);