From ecef13338e1036884d079d2aa8ddd55a5c3da12d Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Mon, 31 Jul 2023 14:20:38 -0400 Subject: [PATCH] Meta: Only write first output file to depfile There's no advantage to writing more than one file, and it lets the depfile work with older versions of ninja. --- .../LibWeb/BindingsGenerator/main.cpp | 20 +++++++++---------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/main.cpp b/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/main.cpp index b42cb34630..f7ec9cc5c3 100644 --- a/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/main.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/main.cpp @@ -191,18 +191,16 @@ ErrorOr serenity_main(Main::Arguments arguments) auto depfile = TRY(Core::File::open_file_or_standard_stream(depfile_path, Core::File::OpenMode::Write)); StringBuilder depfile_builder; - bool first_file = true; for (StringView s : { constructor_header, constructor_implementation, prototype_header, prototype_implementation, namespace_header, namespace_implementation, iterator_prototype_header, iterator_prototype_implementation, global_mixin_header, global_mixin_implementation }) { - if (!s.is_empty()) { - if (!first_file) { - depfile_builder.append(' '); - } - if (!depfile_prefix.is_empty()) - depfile_builder.append(LexicalPath::join(depfile_prefix, s).string()); - else - depfile_builder.append(s); - first_file = false; - } + if (s.is_empty()) + continue; + + if (!depfile_prefix.is_empty()) + depfile_builder.append(LexicalPath::join(depfile_prefix, s).string()); + else + depfile_builder.append(s); + + break; } depfile_builder.append(':'); for (auto const& path : parser.imported_files()) {