RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-18 11:05:06 +00:00
Code Issues Activity Actions

JSSpecCompiler: Try to get section number even if header parsing failed

Browse source
This commit is contained in:
Dan Klishch 2024-01-20 18:59:03 -05:00 • committed by Andrew Kaster
parent 6b30c4d2f0
commit ed04aff1de
1 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/Parser/SpecParser.cpp
View file

@ -271,10 +271,16 @@ Optional<FailedTextParseDiagnostic> SpecificationClause::parse_header(XML::Node
TextParser parser(ctx, tokens, element); TextParser parser(ctx, tokens, element);
auto parse_result = parser.parse_clause_header(); auto parse_result = parser.parse_clause_header();
if (parse_result.is_error()) if (parse_result.is_error()) {
return parser.get_diagnostic(); // Still try to at least scavenge section number.
if (tokens.size() && tokens[0].type == TokenType::SectionNumber)
ctx.current_logical_scope().section = MUST(String::from_utf8(tokens[0].data));
m_header = parse_result.value(); return parser.get_diagnostic();
}
m_header = parse_result.release_value();
ctx.current_logical_scope().section = MUST(String::from_utf8(m_header.section_number));
return {}; return {};
} }
@ -295,8 +301,6 @@ void SpecificationClause::parse(XML::Node const* element)
return; return;
} }
header_parse_error = parse_header(child); header_parse_error = parse_header(child);
if (!header_parse_error.has_value())
ctx.current_logical_scope().section = MUST(String::from_utf8(m_header.section_number));
} else { } else {
if (element.name == tag_h1) { if (element.name == tag_h1) {
ctx.diag().error(ctx.location_from_xml_offset(child->offset), ctx.diag().error(ctx.location_from_xml_offset(child->offset),