RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 08:04:57 +00:00
Code Issues Activity Actions

LibCore: Rename Stream::read_all to read_until_eof

Browse source 
This generally seems like a better name, especially if we somehow also
need a better name for "read the entire buffer, but not the entire file"
somewhere down the line.
This commit is contained in:
Tim Schumacher 2022-12-11 17:49:00 +01:00 • committed by Andreas Kling
parent 5061a905ff
commit ed4c2f2f8e
65 changed files with 88 additions and 88 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Utilities/xml.cpp
View file

@ -372,7 +372,7 @@ static auto parse(StringView contents)
return Error::from_string_literal("NYI: Nonlocal entity");
auto file = TRY(Core::Stream::File::open(url.path(), Core::Stream::OpenMode::Read));
return DeprecatedString::copy(TRY(file->read_all()));
return DeprecatedString::copy(TRY(file->read_until_eof()));
},
},
};
@ -449,7 +449,7 @@ static void do_run_tests(XML::Document& document)
warnln("Running test {}", url.path());
auto contents = file_result.value()->read_all();
auto contents = file_result.value()->read_until_eof();
if (contents.is_error()) {
warnln("Read error for {}: {}", url.path(), contents.error());
s_test_results.set(url.path(), TestResult::RunnerFailed);
@ -474,7 +474,7 @@ static void do_run_tests(XML::Document& document)
s_test_results.set(url.path(), TestResult::RunnerFailed);
continue;
}
auto contents = file_result.value()->read_all();
auto contents = file_result.value()->read_until_eof();
if (contents.is_error()) {
warnln("Read error for {}: {}", out_path, contents.error());
s_test_results.set(url.path(), TestResult::RunnerFailed);
@ -517,7 +517,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
s_path = Core::File::real_path_for(filename);
auto file = TRY(Core::Stream::File::open(s_path, Core::Stream::OpenMode::Read));
auto contents = TRY(file->read_all());
auto contents = TRY(file->read_until_eof());
auto xml_parser = parse(contents);
auto result = xml_parser.parse();