RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 14:37:43 +00:00
Code Issues Activity Actions

LibWeb: Allow passing a (String) body to XMLHttpRequest.send()

Browse source 
This patch implements the simplest form of send(body): strings.
This commit is contained in:
Andreas Kling 2021-09-27 01:40:21 +02:00
parent 194dc8b25d
commit ed5c807c99
3 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp
View file

@ -157,7 +157,7 @@ DOM::ExceptionOr<void> XMLHttpRequest::open(const String& method, const String&
}
// https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send
DOM::ExceptionOr<void> XMLHttpRequest::send()
DOM::ExceptionOr<void> XMLHttpRequest::send(String const& body)
{
if (m_ready_state != ReadyState::Opened)
return DOM::InvalidStateError::create("XHR readyState is not OPENED");
@ -188,6 +188,8 @@ DOM::ExceptionOr<void> XMLHttpRequest::send()
auto request = LoadRequest::create_for_url_on_page(request_url, m_window->page());
request.set_method(m_method);
if (!body.is_null())
request.set_body(body.to_byte_buffer());
for (auto& it : m_request_headers)
request.set_header(it.key, it.value);

2
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.h
View file

@ -52,7 +52,7 @@ public:
String response_text() const;
DOM::ExceptionOr<void> open(const String& method, const String& url);
DOM::ExceptionOr<void> send();
DOM::ExceptionOr<void> send(String const& body);
DOM::ExceptionOr<void> set_request_header(const String& header, const String& value);

2
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.idl
View file

@ -14,7 +14,7 @@ interface XMLHttpRequest : XMLHttpRequestEventTarget {
undefined open(DOMString method, DOMString url);
undefined setRequestHeader(DOMString name, DOMString value);
undefined send();
undefined send(optional USVString body = {});
ByteString? getResponseHeader(ByteString name);
ByteString getAllResponseHeaders();