RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:27:45 +00:00
Code Issues Activity Actions

Kernel/VirtIO: Defer initialization of device out of the constructor

Browse source 
This ensures we safely handle interrupts (which can call virtual
functions), so they don't happen in the constructor - this pattern can
lead to a crash, if we are still in the constructor context because
not all methods are available for usage (some are pure virtual,
so it's possible to call __cxa_pure_virtual).

Also, under some conditions like adding a PCI device via PCI-passthrough
mechanism in QEMU, it became exposed to the eye that the code asserts on
RNG::handle_device_config_change(). That device has no configuration but
if the hypervisor still misbehaves and tries to configure it, we should
simply return false to indicate nothing happened.
This commit is contained in:
Liav A 2021-09-04 08:42:31 +03:00 • committed by Andreas Kling
parent e490c17bde
commit ed6c1f53af
9 changed files with 47 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Kernel/Bus/VirtIO/RNG.cpp
View file

@ -14,9 +14,9 @@ UNMAP_AFTER_INIT NonnullRefPtr<RNG> RNG::must_create(PCI::Address address)
return adopt_ref_if_nonnull(new RNG(address)).release_nonnull();
}
UNMAP_AFTER_INIT RNG::RNG(PCI::Address address)
: VirtIO::Device(address)
UNMAP_AFTER_INIT void RNG::initialize()
{
Device::initialize();
bool success = negotiate_features([&](auto) {
return 0;
});
@ -33,9 +33,14 @@ UNMAP_AFTER_INIT RNG::RNG(PCI::Address address)
}
}
UNMAP_AFTER_INIT RNG::RNG(PCI::Address address)
: VirtIO::Device(address)
{
}
bool RNG::handle_device_config_change()
{
VERIFY_NOT_REACHED(); // Device has no config
return false; // Device has no config
}
void RNG::handle_queue_update(u16 queue_index)