RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:47:45 +00:00
Code Issues Activity Actions

LibC: Fix memory leak in realpath

Browse source
This commit is contained in:
Ben Wiederhake 2021-01-15 22:12:56 +01:00 • committed by Andreas Kling
parent 2a8baf9582
commit ed857bc06e
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibC/stdlib.cpp
View file

@ -1049,11 +1049,16 @@ char* realpath(const char* pathname, char* buffer)
return nullptr; return nullptr;
} }
size_t size = PATH_MAX; size_t size = PATH_MAX;
if (buffer == nullptr) bool self_allocated = false;
if (buffer == nullptr) {
buffer = (char*)malloc(size); buffer = (char*)malloc(size);
self_allocated = true;
}
Syscall::SC_realpath_params params { { pathname, strlen(pathname) }, { buffer, size } }; Syscall::SC_realpath_params params { { pathname, strlen(pathname) }, { buffer, size } };
int rc = syscall(SC_realpath, &params); int rc = syscall(SC_realpath, &params);
if (rc < 0) { if (rc < 0) {
if (self_allocated)
free(buffer);
errno = -rc; errno = -rc;
return nullptr; return nullptr;
} }