From ed9c79e131769d060f7538664eb301d41446a3e1 Mon Sep 17 00:00:00 2001
From: Ali Mohammad Pur <ali.mpfard@gmail.com>
Date: Wed, 15 Dec 2021 16:06:07 +0330
Subject: [PATCH] LibWeb: Use ByteBuffer::copy() instead of a manual copy in
 SubtleCrypto

Also use the HashManager(HashKind) constructor instead of the default
constructor + manual initialize() call.
---
 Userland/Libraries/LibWeb/Crypto/SubtleCrypto.cpp | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/Userland/Libraries/LibWeb/Crypto/SubtleCrypto.cpp b/Userland/Libraries/LibWeb/Crypto/SubtleCrypto.cpp
index a77ac50bce..8835b701dc 100644
--- a/Userland/Libraries/LibWeb/Crypto/SubtleCrypto.cpp
+++ b/Userland/Libraries/LibWeb/Crypto/SubtleCrypto.cpp
@@ -59,19 +59,16 @@ JS::Promise* SubtleCrypto::digest(String const& algorithm, JS::Handle<JS::Object
     // 7. If the following steps or referenced procedures say to throw an error, reject promise with the returned error and then terminate the algorithm.
 
     // 8. Let result be the result of performing the digest operation specified by normalizedAlgorithm using algorithm, with data as message.
-    ::Crypto::Hash::Manager hash;
-    hash.initialize(hash_kind);
+    ::Crypto::Hash::Manager hash { hash_kind };
     hash.update(*data_buffer);
+
     auto digest = hash.digest();
-    auto const* digest_data = digest.immutable_data();
-    auto result_buffer = ByteBuffer::create_zeroed(hash.digest_size());
+    auto result_buffer = ByteBuffer::copy(digest.immutable_data(), hash.digest_size());
     if (!result_buffer.has_value()) {
         auto* error = wrap(wrapper()->global_object(), DOM::OperationError::create("Failed to create result buffer"));
         promise->reject(error);
         return promise;
     }
-    for (size_t i = 0; i < hash.digest_size(); ++i)
-        (*result_buffer)[i] = digest_data[i];
 
     auto* result = JS::ArrayBuffer::create(global_object, result_buffer.release_value());