RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 16:54:57 +00:00
Code Issues Activity Actions

AK: Remove must_set() from JsonArray

Browse source 
Due to 582c55a, both `must_set()` and `set()` should be providing the
same behavior. Not only is that a reason to remove `must_set()`, but
it also performs erroneous behavior since it inserts an element at
a specified index instead of modifying an element at that index.
This commit is contained in:
Kemal Zebari 2023-05-08 13:53:29 -07:00 • committed by Andreas Kling
parent c7e08c3266
commit eda2a2f5da
2 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
AK/JsonArray.h
View file

@ -62,7 +62,6 @@ public:
[[nodiscard]] JsonValue take(size_t index) { return m_values.take(index); } [[nodiscard]] JsonValue take(size_t index) { return m_values.take(index); }
void must_append(JsonValue value) { m_values.append(move(value)); } void must_append(JsonValue value) { m_values.append(move(value)); }
void must_set(size_t index, JsonValue value) { m_values.insert(index, move(value)); }
void clear() { m_values.clear(); } void clear() { m_values.clear(); }
ErrorOr<void> append(JsonValue value) { return m_values.try_append(move(value)); } ErrorOr<void> append(JsonValue value) { return m_values.try_append(move(value)); }

2
Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp
View file

@ -203,7 +203,7 @@ static ErrorOr<JsonValue, ExecuteScriptResultType> clone_an_object(JS::Realm& re
[&](JsonArray& array) { [&](JsonArray& array) {
// NOTE: If this was a JS array, only indexed properties would be serialized anyway. // NOTE: If this was a JS array, only indexed properties would be serialized anyway.
if (name.is_number()) if (name.is_number())
array.must_set(name.as_number(), cloned_property_result.value()); array.set(name.as_number(), cloned_property_result.value());
}, },
[&](JsonObject& object) { [&](JsonObject& object) {
object.set(name.to_string(), cloned_property_result.value()); object.set(name.to_string(), cloned_property_result.value());