RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 05:07:34 +00:00
Code Issues Activity Actions

LibWeb: Add GC finalizer to DOM::NodeIterator

Browse source 
It's potentially unsafe to access `m_root` in the destructor since it
may have been swept, so move unregistration of the NodeIterator into a
GC finalizer instead.
This commit is contained in:
Andreas Kling 2022-10-20 19:46:39 +02:00
parent e7da96acaf
commit eda566d112
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/DOM/NodeIterator.cpp
View file

@ -19,8 +19,11 @@ NodeIterator::NodeIterator(Node& root)
root.document().register_node_iterator({}, *this); root.document().register_node_iterator({}, *this);
} }
NodeIterator::~NodeIterator() NodeIterator::~NodeIterator() = default;
void NodeIterator::finalize()
{ {
Base::finalize();
m_root->document().unregister_node_iterator({}, *this); m_root->document().unregister_node_iterator({}, *this);
} }

1
Userland/Libraries/LibWeb/DOM/NodeIterator.h
View file

@ -38,6 +38,7 @@ private:
explicit NodeIterator(Node& root); explicit NodeIterator(Node& root);
virtual void visit_edges(Cell::Visitor&) override; virtual void visit_edges(Cell::Visitor&) override;
virtual void finalize() override;
enum class Direction { enum class Direction {
Next, Next,