RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 06:02:44 +00:00
Code Issues Activity Actions

LibWeb: Fix hit-testing for button element

Browse source 
Change 'dom_node_for_event_dispatch' to locate the closest layout node
with a DOM node instead of only checking the direct ancestor.

This fixes hit-testing for buttons because they are wrapped into
multiple anonymous layout nodes (internally we use flex formatting for
them).
This commit is contained in:
Aliaksandr Kalenik 2024-02-12 14:58:10 +01:00 • committed by Alexander Kalenik
parent 8e21bbf7bf
commit edab67d5e8
3 changed files with 28 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/hit_testing/button.txt Normal file
View file

@ -0,0 +1 @@
Button Clicked!

21
Tests/LibWeb/Text/input/hit_testing/button.html Normal file
View file

@ -0,0 +1,21 @@
<!DOCTYPE html>
<style>
#btn {
background-color: gold;
font-size: 100px;
width: 500px;
border: none;
}
</style>
<script src="../include.js"></script>
<button type="submit" id="btn">Button</button>
<script>
asyncTest(done => {
const brn = document.getElementById("btn");
btn.onclick = () => {
println("Clicked!");
done();
};
internals.click(50, 50);
});
</script>

8
Userland/Libraries/LibWeb/Page/EventHandler.cpp
View file

@ -34,8 +34,12 @@ static JS::GCPtr<DOM::Node> dom_node_for_event_dispatch(Painting::Paintable& pai
return node;
if (auto node = paintable.dom_node())
return node;
if (auto* layout_parent = paintable.layout_node().parent())
return layout_parent->dom_node();
auto* layout_parent = paintable.layout_node().parent();
while (layout_parent) {
if (auto* node = layout_parent->dom_node())
return node;
layout_parent = layout_parent->parent();
}
return nullptr;
}