From edb3e71c1bebb146d19e41d89cef6baecf1b820b Mon Sep 17 00:00:00 2001 From: sin-ack Date: Wed, 3 Nov 2021 08:02:04 +0000 Subject: [PATCH] WindowServer: Add missing window_was_constructed call In 2e6bb987a31179eddcd3f85f405ad9e8c1e2bc24 the "did_construct" API in Core::Object was removed, since it had only one user. For a replacement, the Window would manually call the frame's "frame_was_constructed" method. However, WindowServer::Window has two constructors, and only one of them called this method. This caused windows to spawn without buttons and various other breakage that spawned from this. --- Userland/Services/WindowServer/Window.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/Userland/Services/WindowServer/Window.cpp b/Userland/Services/WindowServer/Window.cpp index c33acde106..0b4e64efcd 100644 --- a/Userland/Services/WindowServer/Window.cpp +++ b/Userland/Services/WindowServer/Window.cpp @@ -111,6 +111,7 @@ Window::Window(ClientConnection& client, WindowType window_type, int window_id, if (parent_window) set_parent_window(*parent_window); WindowManager::the().add_window(*this); + frame().window_was_constructed({}); } Window::~Window()