RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 11:37:44 +00:00
Code Issues Activity Actions

LibPDF: Break weird dependency cycle

Browse source 
Old situation:
Object.h defines Object
Object.h defines ArrayObject
ArrayObject requires the definition of Object
ArrayObject requires the definition of Value
Value.h defines Value
Value requires the definition of Object

Therefore, a file with the single line "#include <Value.h>" used to
raise compilation errors; certainly not something that one might expect
from a library.

This patch splits up the definitions in Object.h to break the cycle.
Now, Object.h only defines Object, Value.h still only defines Value (and
includes Object.h), and the new header ObjectDerivatives.h defines
ArrayObject (and includes both Object.h and Value.h).
This commit is contained in:
Ben Wiederhake 2021-09-17 02:28:52 +02:00 • committed by Ali Mohammad Pur
parent 7ddd11729d
commit edc0cd29f8
8 changed files with 218 additions and 200 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibPDF/ColorSpace.cpp
View file

@ -6,6 +6,7 @@
#include <LibPDF/ColorSpace.h>
#include <LibPDF/CommonNames.h>
#include <LibPDF/ObjectDerivatives.h>
namespace PDF {