Meta+LibC through LibHTTP: Make clang-format-10 clean

Why break at LibHTTP? Because "Meta+Libraries" would be insanely large,
and breaking between LibHTTP and LibJS makes the commits roughly evenly large.

Libraries/LibC/arpa/inet.h

@@ -37,7 +37,7 @@ __BEGIN_DECLS
 const char* inet_ntop(int af, const void* src, char* dst, socklen_t);
 int inet_pton(int af, const char* src, void* dst);
 
-static inline int inet_aton(const char *cp, struct in_addr *inp)
+static inline int inet_aton(const char* cp, struct in_addr* inp)
 {
     return inet_pton(AF_INET, cp, inp);
 }

Libraries/LibC/dlfcn.cpp

@@ -32,8 +32,8 @@
 #include <stdlib.h>
 #include <sys/stat.h>
 
-#include <AK/LexicalPath.h>
 #include <AK/HashMap.h>
+#include <AK/LexicalPath.h>
 #include <AK/RefPtr.h>
 #include <AK/ScopeGuard.h>
 #include <AK/String.h>
@@ -85,7 +85,8 @@ void* dlopen(const char* filename, int flags)
 
     ScopeGuard close_fd_guard([fd]() { close(fd); });
 
-    struct stat file_stats{};
+    struct stat file_stats {
+    };
 
     int ret = fstat(fd, &file_stats);
     if (ret < 0) {

Libraries/LibC/iconv.h

@@ -26,8 +26,8 @@
 
 #pragma once
 
-#include <sys/cdefs.h>
 #include <stddef.h>
+#include <sys/cdefs.h>
 
 __BEGIN_DECLS
 

Libraries/LibC/limits.h

@@ -29,7 +29,7 @@
 #include <bits/stdint.h>
 
 #ifndef PAGE_SIZE
-#define PAGE_SIZE 4096
+#    define PAGE_SIZE 4096
 #endif
 
 #define PATH_MAX 4096

Libraries/LibC/mallocdefs.h

@@ -28,4 +28,3 @@
 
 #define MALLOC_SCRUB_BYTE 0xdc
 #define FREE_SCRUB_BYTE 0xed
-

Libraries/LibC/setjmp.h

@@ -26,9 +26,9 @@
 
 #pragma once
 
+#include <bits/stdint.h>
 #include <signal.h>
 #include <stdbool.h>
-#include <bits/stdint.h>
 #include <sys/cdefs.h>
 #include <sys/types.h>
 

Libraries/LibC/signal.h

@@ -64,7 +64,7 @@ struct sigaction {
 int kill(pid_t, int sig);
 int killpg(int pgrp, int sig);
 sighandler_t signal(int sig, sighandler_t);
-int pthread_sigmask(int how, const sigset_t *set, sigset_t *ol_dset);
+int pthread_sigmask(int how, const sigset_t* set, sigset_t* ol_dset);
 int sigaction(int sig, const struct sigaction* act, struct sigaction* old_act);
 int sigemptyset(sigset_t*);
 int sigfillset(sigset_t*);

Libraries/LibC/spawn.cpp

@@ -34,14 +34,14 @@
 
 #include <spawn.h>
 
+#include <AK/Function.h>
+#include <AK/Vector.h>
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <unistd.h>
 #include <sys/stat.h>
 #include <sys/types.h>
-#include <AK/Function.h>
+#include <unistd.h>
-#include <AK/Vector.h>
 
 struct posix_spawn_file_actions_state {
     Vector<Function<int()>, 4> actions;
@@ -286,5 +286,4 @@ int posix_spawnattr_setsigmask(posix_spawnattr_t* attr, const sigset_t* sigmask)
     attr->sigmask = *sigmask;
     return 0;
 }
-
 }

Libraries/LibC/stddef.h

@@ -28,13 +28,13 @@
 
 #ifndef KERNEL
 
-#include <sys/cdefs.h>
+#    include <sys/cdefs.h>
 
-#ifdef __cplusplus
+#    ifdef __cplusplus
 #        define NULL nullptr
-#else
+#    else
 #        define NULL ((void*)0)
-#endif
+#    endif
 
 typedef __PTRDIFF_TYPE__ ptrdiff_t;
 typedef __SIZE_TYPE__ size_t;

Libraries/LibC/stdio.h

@@ -28,9 +28,9 @@
 
 #define _STDIO_H // Make GMP believe we exist.
 
+#include <bits/FILE.h>
 #include <limits.h>
 #include <stdarg.h>
-#include <bits/FILE.h>
 #include <sys/cdefs.h>
 #include <sys/types.h>
 

Libraries/LibCore/ArgsParser.cpp

@@ -334,7 +334,7 @@ void ArgsParser::add_positional_argument(double& value, const char* help_string,
         required == Required::Yes ? 1 : 0,
         1,
         [&value](const char* s) {
-            char *p;
+            char* p;
             double v = strtod(s, &p);
             bool valid_value = !isnan(v) && p != s;
             if (valid_value) {

Libraries/LibCore/ElapsedTimer.h

@@ -32,7 +32,7 @@ namespace Core {
 
 class ElapsedTimer {
 public:
-    ElapsedTimer() {}
+    ElapsedTimer() { }
 
     bool is_valid() const { return m_valid; }
     void start();

Libraries/LibCore/MimeData.h

@@ -37,7 +37,7 @@ class MimeData : public Object {
     C_OBJECT(MimeData);
 
 public:
-    virtual ~MimeData() {}
+    virtual ~MimeData() { }
 
     ByteBuffer data(const String& mime_type) const { return m_data.get(mime_type).value_or({}); }
     void set_data(const String& mime_type, const ByteBuffer& data) { m_data.set(mime_type, data); }
@@ -56,7 +56,7 @@ public:
     void set_urls(const Vector<URL>&);
 
 private:
-    MimeData() {}
+    MimeData() { }
 
     HashMap<String, ByteBuffer> m_data;
 };

Libraries/LibCrypto/Checksum/Adler32.h

@@ -34,7 +34,7 @@ namespace Crypto::Checksum {
 
 class Adler32 : public ChecksumFunction<u32> {
 public:
-    Adler32() {}
+    Adler32() { }
     Adler32(ReadonlyBytes data)
     {
         update(data);

Libraries/LibCrypto/Checksum/CRC32.h

@@ -54,7 +54,8 @@ struct Table {
         }
     }
 
-    constexpr u32 operator[](int index) const {
+    constexpr u32 operator[](int index) const
+    {
         return data[index];
     }
 };
@@ -63,7 +64,7 @@ constexpr static auto table = Table();
 
 class CRC32 : public ChecksumFunction<u32> {
 public:
-    CRC32() {}
+    CRC32() { }
     CRC32(ReadonlyBytes data)
     {
         update(data);

Libraries/LibDesktop/Launcher.cpp

@@ -74,7 +74,7 @@ private:
         : IPC::ServerConnection<LaunchClientEndpoint, LaunchServerEndpoint>(*this, "/tmp/portal/launch")
     {
     }
-    virtual void handle(const Messages::LaunchClient::Dummy&) override {}
+    virtual void handle(const Messages::LaunchClient::Dummy&) override { }
 };
 
 bool Launcher::open(const URL& url, const String& handler_name)

Libraries/LibDesktop/Launcher.h

@@ -43,7 +43,7 @@ public:
         UserDefault
     };
 
-    struct Details: public RefCounted<Details> {
+    struct Details : public RefCounted<Details> {
 
         String name;
         String executable;

Libraries/LibELF/DynamicObject.h

@@ -52,7 +52,7 @@ public:
         {
         }
 
-        ~DynamicEntry() {}
+        ~DynamicEntry() { }
 
         Elf32_Sword tag() const { return m_dyn.d_tag; }
         Elf32_Addr ptr() const { return m_dyn.d_un.d_ptr; }
@@ -71,7 +71,7 @@ public:
         {
         }
 
-        ~Symbol() {}
+        ~Symbol() { }
 
         const char* name() const { return m_dynamic.symbol_string_table_string(m_sym.st_name); }
         unsigned section_index() const { return m_sym.st_shndx; }
@@ -99,7 +99,7 @@ public:
             , m_name(name)
         {
         }
-        ~Section() {}
+        ~Section() { }
 
         const char* name() const { return m_name; }
         unsigned offset() const { return m_section_offset; }
@@ -140,7 +140,7 @@ public:
         {
         }
 
-        ~Relocation() {}
+        ~Relocation() { }
 
         unsigned offset_in_section() const { return m_offset_in_section; }
         unsigned offset() const { return m_rel.r_offset; }

Libraries/LibELF/Loader.h

@@ -45,7 +45,7 @@ namespace ELF {
 
 class Loader : public RefCounted<Loader> {
 public:
-    static NonnullRefPtr<Loader> create(const u8* data, size_t size, bool verbose_logging=true) { return adopt(*new Loader(data, size, verbose_logging)); }
+    static NonnullRefPtr<Loader> create(const u8* data, size_t size, bool verbose_logging = true) { return adopt(*new Loader(data, size, verbose_logging)); }
     ~Loader();
 
     bool load();

Libraries/LibELF/Validation.cpp

@@ -26,8 +26,8 @@
 
 #include <AK/Assertions.h>
 #include <AK/String.h>
-#include <LibELF/exec_elf.h>
 #include <LibELF/Validation.h>
+#include <LibELF/exec_elf.h>
 
 namespace ELF {
 

Libraries/LibELF/Validation.h

@@ -30,7 +30,7 @@
 
 namespace ELF {
 
-bool validate_elf_header(const Elf32_Ehdr& elf_header, size_t file_size, bool verbose=true);
+bool validate_elf_header(const Elf32_Ehdr& elf_header, size_t file_size, bool verbose = true);
 bool validate_program_headers(const Elf32_Ehdr& elf_header, size_t file_size, u8* buffer, size_t buffer_size, String& interpreter_path);
 
 } // end namespace ELF

Libraries/LibGUI/AboutDialog.cpp

@@ -29,8 +29,8 @@
 #include <LibGUI/AboutDialog.h>
 #include <LibGUI/BoxLayout.h>
 #include <LibGUI/Button.h>
-#include <LibGUI/Label.h>
 #include <LibGUI/ImageWidget.h>
+#include <LibGUI/Label.h>
 #include <LibGUI/Widget.h>
 #include <LibGfx/Font.h>
 

Libraries/LibGUI/ActionGroup.h

@@ -34,8 +34,8 @@ namespace GUI {
 
 class ActionGroup : public Weakable<ActionGroup> {
 public:
-    ActionGroup() {}
+    ActionGroup() { }
-    ~ActionGroup() {}
+    ~ActionGroup() { }
 
     void add_action(Action&);
     void remove_action(Action&);

Libraries/LibGUI/BoxLayout.h

@@ -34,8 +34,9 @@ namespace GUI {
 
 class BoxLayout : public Layout {
     C_OBJECT(BoxLayout);
+
 public:
-    virtual ~BoxLayout() override {}
+    virtual ~BoxLayout() override { }
 
     Gfx::Orientation orientation() const { return m_orientation; }
 
@@ -50,22 +51,24 @@ private:
 
 class VerticalBoxLayout final : public BoxLayout {
     C_OBJECT(VerticalBoxLayout);
+
 public:
     explicit VerticalBoxLayout()
         : BoxLayout(Gfx::Orientation::Vertical)
     {
     }
-    virtual ~VerticalBoxLayout() override {}
+    virtual ~VerticalBoxLayout() override { }
 };
 
 class HorizontalBoxLayout final : public BoxLayout {
     C_OBJECT(HorizontalBoxLayout);
+
 public:
     explicit HorizontalBoxLayout()
         : BoxLayout(Gfx::Orientation::Horizontal)
     {
     }
-    virtual ~HorizontalBoxLayout() override {}
+    virtual ~HorizontalBoxLayout() override { }
 };
 
 }

Libraries/LibGUI/Button.h

@@ -28,10 +28,10 @@
 
 #include <AK/Function.h>
 #include <AK/String.h>
+#include <LibGUI/AbstractButton.h>
 #include <LibGfx/Bitmap.h>
 #include <LibGfx/StylePainter.h>
 #include <LibGfx/TextAlignment.h>
-#include <LibGUI/AbstractButton.h>
 
 namespace GUI {
 

Libraries/LibGUI/ColorPicker.cpp

@@ -128,7 +128,6 @@ public:
 private:
     CustomColorWidget(Color);
 
-
     RefPtr<ColorField> m_color_field;
     RefPtr<ColorSlider> m_color_slider;
 };

Libraries/LibGUI/Command.h

@@ -34,13 +34,13 @@ class Command {
 public:
     virtual ~Command();
 
-    virtual void undo() {}
+    virtual void undo() { }
-    virtual void redo() {}
+    virtual void redo() { }
 
     String action_text() const { return m_action_text; }
 
 protected:
-    Command() {}
+    Command() { }
     void set_action_text(const String& text) { m_action_text = text; }
 
 private:

Libraries/LibGUI/CppSyntaxHighlighter.h

@@ -32,7 +32,7 @@ namespace GUI {
 
 class CppSyntaxHighlighter final : public SyntaxHighlighter {
 public:
-    CppSyntaxHighlighter() {}
+    CppSyntaxHighlighter() { }
     virtual ~CppSyntaxHighlighter() override;
 
     virtual bool is_identifier(void*) const override;

Libraries/LibGUI/FontDatabase.cpp

@@ -26,8 +26,8 @@
 
 #include <AK/QuickSort.h>
 #include <LibCore/DirIterator.h>
-#include <LibGfx/Font.h>
 #include <LibGUI/FontDatabase.h>
+#include <LibGfx/Font.h>
 #include <dirent.h>
 #include <stdio.h>
 #include <stdlib.h>

Libraries/LibGUI/Frame.h

@@ -26,8 +26,8 @@
 
 #pragma once
 
-#include <LibGfx/StylePainter.h>
 #include <LibGUI/Widget.h>
+#include <LibGfx/StylePainter.h>
 
 namespace GUI {
 

Libraries/LibGUI/INISyntaxHighlighter.h

@@ -32,7 +32,7 @@ namespace GUI {
 
 class IniSyntaxHighlighter final : public SyntaxHighlighter {
 public:
-    IniSyntaxHighlighter() {}
+    IniSyntaxHighlighter() { }
     virtual ~IniSyntaxHighlighter() override;
 
     virtual bool is_identifier(void*) const override;

Libraries/LibGUI/Icon.h

@@ -36,13 +36,13 @@ namespace GUI {
 class IconImpl : public RefCounted<IconImpl> {
 public:
     static NonnullRefPtr<IconImpl> create() { return adopt(*new IconImpl); }
-    ~IconImpl() {}
+    ~IconImpl() { }
 
     const Gfx::Bitmap* bitmap_for_size(int) const;
     void set_bitmap_for_size(int, RefPtr<Gfx::Bitmap>&&);
 
 private:
-    IconImpl() {}
+    IconImpl() { }
     HashMap<int, RefPtr<Gfx::Bitmap>> m_bitmaps;
 };
 
@@ -53,7 +53,7 @@ public:
     explicit Icon(RefPtr<Gfx::Bitmap>&&, RefPtr<Gfx::Bitmap>&&);
     explicit Icon(const IconImpl&);
     Icon(const Icon&);
-    ~Icon() {}
+    ~Icon() { }
 
     static Icon default_icon(const StringView&);
 

Libraries/LibGUI/Label.h

@@ -26,8 +26,8 @@
 
 #pragma once
 
-#include <LibGfx/TextAlignment.h>
 #include <LibGUI/Frame.h>
+#include <LibGfx/TextAlignment.h>
 
 namespace GUI {
 

Libraries/LibGUI/Margins.h

@@ -30,7 +30,7 @@ namespace GUI {
 
 class Margins {
 public:
-    Margins() {}
+    Margins() { }
     Margins(int left, int top, int right, int bottom)
         : m_left(left)
         , m_top(top)
@@ -38,7 +38,7 @@ public:
         , m_bottom(bottom)
     {
     }
-    ~Margins() {}
+    ~Margins() { }
 
     bool is_null() const { return !m_left && !m_top && !m_right && !m_bottom; }
 

Libraries/LibGUI/MessageBox.cpp

@@ -26,8 +26,8 @@
 
 #include <LibGUI/BoxLayout.h>
 #include <LibGUI/Button.h>
-#include <LibGUI/Label.h>
 #include <LibGUI/ImageWidget.h>
+#include <LibGUI/Label.h>
 #include <LibGUI/MessageBox.h>
 #include <LibGfx/Font.h>
 #include <stdio.h>

Libraries/LibGUI/ModelSelection.h

@@ -28,10 +28,10 @@
 
 #include <AK/Badge.h>
 #include <AK/HashTable.h>
+#include <AK/Noncopyable.h>
 #include <AK/TemporaryChange.h>
 #include <AK/Vector.h>
 #include <LibGUI/ModelIndex.h>
-#include <AK/Noncopyable.h>
 
 namespace GUI {
 

Libraries/LibGUI/Notification.cpp

@@ -45,9 +45,8 @@ private:
     NotificationServerConnection()
         : IPC::ServerConnection<NotificationClientEndpoint, NotificationServerEndpoint>(*this, "/tmp/portal/notify")
     {
-
     }
-    virtual void handle(const Messages::NotificationClient::Dummy&) override {}
+    virtual void handle(const Messages::NotificationClient::Dummy&) override { }
 };
 
 Notification::Notification()

Libraries/LibGUI/ProcessChooser.h

@@ -26,8 +26,8 @@
 
 #pragma once
 
-#include <LibGUI/Dialog.h>
 #include <LibCore/Timer.h>
+#include <LibGUI/Dialog.h>
 
 namespace GUI {
 

Libraries/LibGUI/ResizeCorner.cpp

@@ -24,11 +24,11 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#include <LibGfx/CharacterBitmap.h>
-#include <LibGfx/Palette.h>
 #include <LibGUI/Painter.h>
 #include <LibGUI/ResizeCorner.h>
 #include <LibGUI/Window.h>
+#include <LibGfx/CharacterBitmap.h>
+#include <LibGfx/Palette.h>
 
 namespace GUI {
 

Libraries/LibGUI/ScrollableWidget.h

@@ -82,7 +82,7 @@ protected:
     virtual void custom_layout() override;
     virtual void resize_event(ResizeEvent&) override;
     virtual void mousewheel_event(MouseEvent&) override;
-    virtual void did_scroll() {}
+    virtual void did_scroll() { }
     void set_content_size(const Gfx::IntSize&);
     void set_size_occupied_by_fixed_elements(const Gfx::IntSize&);
 

Libraries/LibGUI/Shortcut.h

@@ -33,7 +33,7 @@ namespace GUI {
 
 class Shortcut {
 public:
-    Shortcut() {}
+    Shortcut() { }
     Shortcut(u8 modifiers, KeyCode key)
         : m_modifiers(modifiers)
         , m_key(key)

Libraries/LibGUI/Slider.h

@@ -102,7 +102,7 @@ private:
 class VerticalSlider final : public Slider {
     C_OBJECT(VerticalSlider)
 public:
-    virtual ~VerticalSlider() override {}
+    virtual ~VerticalSlider() override { }
 
 private:
     VerticalSlider()
@@ -114,7 +114,7 @@ private:
 class HorizontalSlider final : public Slider {
     C_OBJECT(HorizontalSlider)
 public:
-    virtual ~HorizontalSlider() override {}
+    virtual ~HorizontalSlider() override { }
 
 private:
     HorizontalSlider()

Libraries/LibGUI/SyntaxHighlighter.h

@@ -64,7 +64,7 @@ public:
     void cursor_did_change();
 
 protected:
-    SyntaxHighlighter() {}
+    SyntaxHighlighter() { }
 
     WeakPtr<TextEditor> m_editor;
 

Libraries/LibGUI/TextEditor.h

@@ -181,7 +181,7 @@ protected:
     virtual void context_menu_event(ContextMenuEvent&) override;
     virtual void resize_event(ResizeEvent&) override;
     virtual void theme_change_event(ThemeChangeEvent&) override;
-    virtual void cursor_did_change() {}
+    virtual void cursor_did_change() { }
     Gfx::IntRect ruler_content_rect(size_t line) const;
 
     TextPosition text_position_at(const Gfx::IntPoint&) const;

Libraries/LibGUI/TextPosition.h

@@ -33,7 +33,7 @@ namespace GUI {
 
 class TextPosition {
 public:
-    TextPosition() {}
+    TextPosition() { }
     TextPosition(size_t line, size_t column)
         : m_line(line)
         , m_column(column)

Libraries/LibGUI/TextRange.h

@@ -33,7 +33,7 @@ namespace GUI {
 
 class TextRange {
 public:
-    TextRange() {}
+    TextRange() { }
     TextRange(const TextPosition& start, const TextPosition& end)
         : m_start(start)
         , m_end(end)

Libraries/LibGUI/ToolBar.cpp

@@ -24,13 +24,13 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#include <LibGfx/Palette.h>
 #include <LibGUI/Action.h>
 #include <LibGUI/ActionGroup.h>
 #include <LibGUI/BoxLayout.h>
 #include <LibGUI/Button.h>
 #include <LibGUI/Painter.h>
 #include <LibGUI/ToolBar.h>
+#include <LibGfx/Palette.h>
 
 namespace GUI {
 
@@ -86,7 +86,7 @@ public:
         set_size_policy(SizePolicy::Fixed, SizePolicy::Fixed);
         set_preferred_size(8, 18);
     }
-    virtual ~SeparatorWidget() override {}
+    virtual ~SeparatorWidget() override { }
 
     virtual void paint_event(PaintEvent& event) override
     {
@@ -111,9 +111,6 @@ void ToolBar::paint_event(PaintEvent& event)
     Painter painter(*this);
     painter.add_clip_rect(event.rect());
 
-    //if (m_has_frame)
-//        Gfx::StylePainter::paint_surface(painter, rect(), palette(), x() != 0, y() != 0);
-//    else
     painter.fill_rect(event.rect(), palette().button());
 }
 

Libraries/LibGUI/Variant.h

@@ -27,9 +27,9 @@
 #pragma once
 
 #include <AK/String.h>
-#include <LibGfx/Font.h>
-#include <LibGfx/Bitmap.h>
 #include <LibGUI/Icon.h>
+#include <LibGfx/Bitmap.h>
+#include <LibGfx/Font.h>
 
 namespace GUI {
 

Libraries/LibGfx/Emoji.cpp

@@ -26,8 +26,8 @@
 
 #include <AK/HashMap.h>
 #include <AK/String.h>
-#include <LibGfx/Emoji.h>
 #include <LibGfx/Bitmap.h>
+#include <LibGfx/Emoji.h>
 
 namespace Gfx {
 

Libraries/LibGfx/Path.h

@@ -31,8 +31,8 @@
 #include <AK/Optional.h>
 #include <AK/String.h>
 #include <AK/Vector.h>
-#include <LibGfx/Point.h>
 #include <LibGfx/Forward.h>
+#include <LibGfx/Point.h>
 
 namespace Gfx {
 

Libraries/LibGfx/ShareableBitmap.h

@@ -34,7 +34,7 @@ namespace Gfx {
 
 class ShareableBitmap {
 public:
-    ShareableBitmap() {}
+    ShareableBitmap() { }
     explicit ShareableBitmap(const Gfx::Bitmap&);
 
     bool is_valid() const { return m_bitmap; }

Libraries/LibGfx/Size.h

@@ -35,7 +35,7 @@ namespace Gfx {
 template<typename T>
 class Size {
 public:
-    Size() {}
+    Size() { }
 
     Size(T w, T h)
         : m_width(w)

Libraries/LibHTTP/HttpRequest.cpp

@@ -188,7 +188,7 @@ Optional<HttpRequest> HttpRequest::from_raw_request(const ByteBuffer& raw_reques
     return request;
 }
 
-void HttpRequest::set_headers(const HashMap<String,String>& headers)
+void HttpRequest::set_headers(const HashMap<String, String>& headers)
 {
     for (auto& it : headers)
         m_headers.append({ it.key, it.value });