RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 22:47:45 +00:00
Code Issues Activity Actions

Ladybird+LibWebView: Migrate input completions to LibWebView callbacks

Browse source
This commit is contained in:
Timothy Flynn 2023-08-23 11:19:21 -04:00 • committed by Tim Flynn
parent 5116e97a9d
commit edec5b1d91
9 changed files with 9 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Ladybird/AppKit/UI/LadybirdWebViewBridge.cpp
View file

@ -133,10 +133,6 @@ Optional<WebViewBridge::Paintable> WebViewBridge::paintable()
return Paintable { *bitmap, bitmap_size };
}
void WebViewBridge::notify_server_did_finish_handling_input_event(bool)
{
}
void WebViewBridge::update_zoom()
{
}

2
Ladybird/AppKit/UI/LadybirdWebViewBridge.h
View file

@ -52,8 +52,6 @@ public:
private:
WebViewBridge(Vector<Gfx::IntRect> screen_rects, float device_pixel_ratio, Optional<StringView> webdriver_content_ipc_path);
virtual void notify_server_did_finish_handling_input_event(bool event_was_accepted) override;
virtual void update_zoom() override;
virtual Gfx::IntRect viewport_rect() const override;
virtual Gfx::IntPoint to_content_position(Gfx::IntPoint widget_position) const override;

7
Ladybird/Qt/WebContentView.cpp
View file

@ -736,13 +736,6 @@ bool WebContentView::event(QEvent* event)
return QAbstractScrollArea::event(event);
}
void WebContentView::notify_server_did_finish_handling_input_event(bool event_was_accepted)
{
// FIXME: Currently Ladybird handles the keyboard shortcuts before passing the event to web content, so
// we don't need to do anything here. But we'll need to once we start asking web content first.
(void)event_was_accepted;
}
ErrorOr<String> WebContentView::dump_layout_tree()
{
return String::from_deprecated_string(client().dump_layout_tree());

2
Ladybird/Qt/WebContentView.h
View file

@ -76,8 +76,6 @@ public:
};
void update_palette(PaletteMode = PaletteMode::Default);
virtual void notify_server_did_finish_handling_input_event(bool event_was_accepted) override;
signals:
void urls_dropped(QList<QUrl> const&);