RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:57:45 +00:00
Code Issues Activity Actions

LibTLS: ECDHE switch from FeatureNotSupported to NotUnderstood error

Browse source 
NotUnderstood will generate a TLS alert with an InternalError instead of
crashing the RequestServer.
This commit is contained in:
Michiel Visser 2022-02-18 15:59:04 +01:00 • committed by Ali Mohammad Pur
parent ab84aa6fb2
commit edee8ab32a
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibTLS/HandshakeServer.cpp
View file

@ -295,15 +295,15 @@ ssize_t TLSv12::handle_ecdhe_rsa_server_key_exchange(ReadonlyBytes buffer)
auto curve_type = buffer[3]; auto curve_type = buffer[3];
if (curve_type != (u8)ECCurveType::NamedCurve) if (curve_type != (u8)ECCurveType::NamedCurve)
return (i8)Error::FeatureNotSupported; return (i8)Error::NotUnderstood;
auto curve = AK::convert_between_host_and_network_endian(ByteReader::load16(buffer.offset_pointer(4))); auto curve = AK::convert_between_host_and_network_endian(ByteReader::load16(buffer.offset_pointer(4)));
if (curve != (u16)NamedCurve::x25519) if (curve != (u16)NamedCurve::x25519)
return (i8)Error::FeatureNotSupported; return (i8)Error::NotUnderstood;
auto server_public_key_length = buffer[6]; auto server_public_key_length = buffer[6];
if (server_public_key_length != x25519_key_size_bytes) if (server_public_key_length != x25519_key_size_bytes)
return (i8)Error::FeatureNotSupported; return (i8)Error::NotUnderstood;
auto server_public_key = buffer.slice(7, server_public_key_length); auto server_public_key = buffer.slice(7, server_public_key_length);
auto server_public_key_copy_result = ByteBuffer::copy(server_public_key); auto server_public_key_copy_result = ByteBuffer::copy(server_public_key);