RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 19:28:12 +00:00
Code Issues Activity Actions

LibWeb: Create a no-op formatting context for childless replaced boxes

Browse source 
This is a hack that allows block-level replaced elements to be flex
items. Flexbox layout currently assumes (in many places) that it's
always possible to create an independent formatting context for each of
its items.
This commit is contained in:
Andreas Kling 2022-04-11 00:39:43 +02:00
parent b1a6a8600a
commit edfa4508a5
1 changed files with 16 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibWeb/Layout/FormattingContext.cpp
View file

@ -75,6 +75,22 @@ bool FormattingContext::creates_block_formatting_context(Box const& box)
OwnPtr<FormattingContext> FormattingContext::create_independent_formatting_context_if_needed(FormattingState& state, Box const& child_box)
{
if (child_box.is_replaced_box() && !child_box.can_have_children()) {
// NOTE: This is a bit strange.
// Basically, we create a pretend formatting context for replaced elements that does nothing.
// This allows other formatting contexts to treat them like elements that actually need inside layout
// without having separate code to handle replaced elements.
// FIXME: Find a better abstraction for this.
struct ReplacedFormattingContext : public FormattingContext {
ReplacedFormattingContext(FormattingState& state, Box const& box)
: FormattingContext(Type::Block, state, box)
{
}
virtual void run(Box const&, LayoutMode) override { }
};
return make<ReplacedFormattingContext>(state, child_box);
}
if (!child_box.can_have_children())
return {};