RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:18:11 +00:00
Code Issues Activity Actions

LibJS: Make AssignmentExpression assign through a Reference

Browse source 
Reference now has assign(Interpreter&, Value) which is used to write
transparently through a Reference into whatever location it refers to.
This commit is contained in:
Andreas Kling 2020-04-27 12:56:09 +02:00
parent 3c4a9e421f
commit ee0bf55127
5 changed files with 66 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Libraries/LibJS/AST.cpp
View file

@ -837,21 +837,17 @@ Value AssignmentExpression::execute(Interpreter& interpreter) const
if (interpreter.exception())
return {};
if (m_lhs->is_identifier()) {
auto name = static_cast<const Identifier&>(*m_lhs).string();
interpreter.set_variable(name, rhs_result);
} else if (m_lhs->is_member_expression()) {
auto object_value = static_cast<const MemberExpression&>(*m_lhs).object().execute(interpreter);
if (interpreter.exception())
return {};
if (auto* object = object_value.to_object(interpreter.heap())) {
auto property_name = static_cast<const MemberExpression&>(*m_lhs).computed_property_name(interpreter);
object->put(property_name, rhs_result);
}
} else {
return interpreter.throw_exception<ReferenceError>("Invalid left-hand side in assignment");
}
auto reference = m_lhs->to_reference(interpreter);
if (interpreter.exception())
return {};
if (reference.is_unresolvable())
return interpreter.throw_exception<ReferenceError>("Invalid left-hand side in assignment");
reference.assign(interpreter, rhs_result);
if (interpreter.exception())
return {};
return rhs_result;
}