RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:07:35 +00:00
Code Issues Activity Actions

LibRegex: Fail early if eof seen after '(?'

Browse source 
Fixes #4583.
This commit is contained in:
AnotherTest 2020-12-28 09:07:17 +03:30 • committed by Andreas Kling
parent 92c073a9d1
commit ee1d9217aa
2 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibRegex/RegexParser.cpp
View file

@ -741,6 +741,11 @@ bool ECMA262Parser::parse_assertion(ByteCode& stack, [[maybe_unused]] size_t& ma
if (!try_skip("(?"))
return false;
if (done()) {
set_error(Error::InvalidCaptureGroup);
return false;
}
ByteCode assertion_stack;
size_t length_dummy = 0;

1
Libraries/LibRegex/Tests/Regex.cpp
View file

@ -500,6 +500,7 @@ TEST_CASE(ECMA262_parse)
{ "(?", regex::Error::InvalidCaptureGroup },
{ "\\u1234", regex::Error::NoError, regex::ECMAScriptFlags::Unicode },
{ "[\\u1234]", regex::Error::NoError, regex::ECMAScriptFlags::Unicode },
{ ",(?", regex::Error::InvalidCaptureGroup }, // #4583
};
for (auto& test : tests) {