RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-17 11:17:36 +00:00
Code Issues Activity Actions

LibWeb: Make flex-box ignore out-of-flow child boxes

Browse source 
Previously, out-of-flow children still took up space inside a flex-box
container, leaving an odd gap. Now they don't! :^)
This commit is contained in:
Sam Atkins 2021-09-15 12:26:12 +01:00 • committed by Andreas Kling
parent 2844f89a83
commit ee671a20cc
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp
View file

@ -238,6 +238,10 @@ void FlexFormattingContext::run(Box& box, LayoutMode)
return IterationDecision::Continue; return IterationDecision::Continue;
} }
// Skip any "out-of-flow" children
if (child_box.is_out_of_flow(*this))
return IterationDecision::Continue;
child_box.set_flex_item(true); child_box.set_flex_item(true);
flex_items.append({ child_box }); flex_items.append({ child_box });
return IterationDecision::Continue; return IterationDecision::Continue;