RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 22:28:12 +00:00
Code Issues Activity Actions

LibRegex: Use match_ordinary_characters() in ECMA262Parser::parse_atom()

Browse source 
Otherwise we would only match TokenType::Char, making all of these invalid:

- /foo,bar/
- /foo\/bar/
- /foo=bar/
- /foo-bar/
- /foo:bar/

Fixes #4243.
This commit is contained in:
Linus Groh 2020-11-29 19:10:46 +00:00 • committed by Andreas Kling
parent 1279d2256c
commit eea7cabdbc
3 changed files with 16 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibRegex/RegexParser.h
View file

@ -90,6 +90,7 @@ protected:
ALWAYS_INLINE bool match(TokenType type) const;
ALWAYS_INLINE bool match(char ch) const;
ALWAYS_INLINE bool match_ordinary_characters();
ALWAYS_INLINE Token consume();
ALWAYS_INLINE Token consume(TokenType type, Error error);
ALWAYS_INLINE bool consume(const String&);
@ -145,7 +146,6 @@ public:
private:
ALWAYS_INLINE bool match_repetition_symbol();
ALWAYS_INLINE bool match_ordinary_characters();
bool parse_internal(ByteCode&, size_t&) override;