RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 10:57:35 +00:00
Code Issues Activity Actions

LibWeb: Stop lying about string types

Browse source
This commit is contained in:
Hendiadyoin1 2023-06-11 19:46:53 +02:00 • committed by Jelle Raaijmakers
parent 9300b9a364
commit eeb15fc10b
5 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/BrowsingContext.cpp
View file

@ -957,7 +957,7 @@ BrowsingContext::ChosenBrowsingContext BrowsingContext::choose_a_browsing_contex
// 6. If name is not an ASCII case-insensitive match for "_blank", then set chosen's name to name.
if (!Infra::is_ascii_case_insensitive_match(name, "_blank"sv))
chosen->set_name(String::from_deprecated_string(name).release_value_but_fixme_should_propagate_errors());
chosen->set_name(String::from_utf8(name).release_value_but_fixme_should_propagate_errors());
}
// --> If the user agent has been configured such that in this instance t will reuse current

2
Userland/Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View file

@ -463,7 +463,7 @@ public:
// empty string, then end the synchronous section, and jump down to the failed with elements step below.
String candiate_src;
if (m_candidate->has_attribute(HTML::AttributeNames::src))
candiate_src = TRY_OR_THROW_OOM(vm, String::from_utf8(m_candidate->attribute(HTML::AttributeNames::src)));
candiate_src = TRY_OR_THROW_OOM(vm, String::from_deprecated_string(m_candidate->attribute(HTML::AttributeNames::src)));
if (candiate_src.is_empty()) {
TRY(failed_with_elements());